Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tab key processed more than once in nested <Popover/>s #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogerso
Copy link

@rogerso rogerso commented Sep 11, 2024

This PR fixes the issue where handleWindowKeydown() is called more than once in nested <Popover>, as each <PopoverPanel> has its own <svelte:window> with an on:keydown handler. The added event.stopImmediatePropagation() makes sure only one handler is called for the same keydown event.

This fixes #180.

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-headlessui-kf6d ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:14am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect tab key behavior in nested Popover
1 participant